mirror of
https://github.com/kjanat/livedash-node.git
synced 2026-02-13 22:35:47 +01:00
- Fix syntax errors in skills markdown files (.github/skills, .opencode/skills) - Change typescript to tsx for code blocks with JSX - Replace ellipsis (...) in array examples with valid syntax - Separate CSS from TypeScript into distinct code blocks - Convert JavaScript object examples to valid JSON in docs - Fix enum definitions with proper comma separation
51 lines
1.1 KiB
Markdown
51 lines
1.1 KiB
Markdown
---
|
|
title: Early Return from Functions
|
|
impact: LOW-MEDIUM
|
|
impactDescription: avoids unnecessary computation
|
|
tags: javascript, functions, optimization, early-return
|
|
---
|
|
|
|
## Early Return from Functions
|
|
|
|
Return early when result is determined to skip unnecessary processing.
|
|
|
|
**Incorrect (processes all items even after finding answer):**
|
|
|
|
```typescript
|
|
function validateUsers(users: User[]) {
|
|
let hasError = false;
|
|
let errorMessage = "";
|
|
|
|
for (const user of users) {
|
|
if (!user.email) {
|
|
hasError = true;
|
|
errorMessage = "Email required";
|
|
}
|
|
if (!user.name) {
|
|
hasError = true;
|
|
errorMessage = "Name required";
|
|
}
|
|
// Continues checking all users even after error found
|
|
}
|
|
|
|
return hasError ? { valid: false, error: errorMessage } : { valid: true };
|
|
}
|
|
```
|
|
|
|
**Correct (returns immediately on first error):**
|
|
|
|
```typescript
|
|
function validateUsers(users: User[]) {
|
|
for (const user of users) {
|
|
if (!user.email) {
|
|
return { valid: false, error: "Email required" };
|
|
}
|
|
if (!user.name) {
|
|
return { valid: false, error: "Name required" };
|
|
}
|
|
}
|
|
|
|
return { valid: true };
|
|
}
|
|
```
|